THRIFT-5947: Fix JavaScript exception constructor implementation (ES6)#3372
Merged
Jens-G merged 1 commit intoapache:masterfrom Apr 8, 2026
Merged
THRIFT-5947: Fix JavaScript exception constructor implementation (ES6)#3372Jens-G merged 1 commit intoapache:masterfrom
Jens-G merged 1 commit intoapache:masterfrom
Conversation
Jens-G
added a commit
to Jens-G/thrift
that referenced
this pull request
Apr 8, 2026
Client: js Add unit tests verifying that ES6-generated exception classes pass the exception name string to super() instead of the args object. This is a regression test for the bug fixed in PR apache#3372, where super(args) caused TBinaryProtocol.writeStringOrBinary to throw. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Jens-G
added a commit
that referenced
this pull request
Apr 9, 2026
Client: js Add unit tests verifying that ES6-generated exception classes pass the exception name string to super() instead of the args object. This is a regression test for the bug fixed in PR #3372, where super(args) caused TBinaryProtocol.writeStringOrBinary to throw. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the JavaScript custom exception constructor implementation.
This thrift custom exception :
results to a constructor which takes a single JS Object with custom properties :
We can check it in the associated TypeScript typings :
The generated code gives the JS object to the constructor of Thrift.TException.
But the Thrift.TException constructor takes a single string argument :
Giving this custom object to the TException (instead of a string) throws unwanted Thrift exceptions in
TBinaryProtocol.prototype.writeStringOrBinary:The fix is to give the name of the custom exception to the constructor of the inherited Thrift exception class (TException).
[skip ci]anywhere in the commit message to free up build resources.